Skip to content

typo #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 20, 2022
Merged

typo #72

merged 4 commits into from
Jul 20, 2022

Conversation

cf-ci-bot-v2
Copy link
Contributor

Pull Request template

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Affected areas

  • UI
  • analytics-reporter
  • api-events
  • api-graphql
  • e2e
  • event-handler
  • GraphQL schema
  • Database layer
  • EventBus
  • Tooling (lint, Lerna etc...)

Special information

  • There is a new library in this PR
  • There is a new integration in this PR
  • This PR Require a new environment variable
  • This PR Require a new feature flag
  • This PR includes a new UI shard component

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

saffi-codefresh
saffi-codefresh approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@saffi-codefresh saffi-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing ci with service yaml check and latest tag.

@saffi-codefresh saffi-codefresh merged commit 5d2d2ef into main Jul 20, 2022
@cf-ci-bot-v2 cf-ci-bot-v2 deleted the typo branch July 20, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@saffi-codefresh saffi-codefresh saffi-codefresh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cf-ci-bot-v2 @saffi-codefresh