feat: use argo-cd community chart instead of cf fork #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
|
/e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Not to be merged yet - only closer to M1.
The PR makes GitOps runtime stop using our argo-helm fork and relies on the OSS argo-helm.
Meaning: our forked CRDS are no longer in use. The changes in those CRDs are not needed anymore (most of the changes are for monorepo controller and at the time of merging this PR it will be available as an OSS sub-dependency)
Why
To simplify supporting multiple GitOps runtime versions in parallel. OSS argo-helm does not have the LTS version model so maintaining multiple versions of forked argo-helm will be a time consuming, error-prone task.
Notes