feat(codefresh-run): add TERMINATE_ON_TIMEOUT argument
#529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `TERMINATE_ON_TIMEOUT` is set to `true` and timeout set in `TIMEOUT_MINS` is expired, terminate child build. Closes #CR-16035
ghost
self-assigned this
itai-codefresh
suggested changes
Dec 20, 2022
itai-codefresh
approved these changes
Dec 20, 2022
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds a new argument to
codefresh-runstep:TERMINATE_ON_TIMEOUT.If set to
trueand timeout fromTIMEOUT_MINSis expired, child build will be terminated.Backward compatibility
New argument defaults to
falseif not passed. Iffalse, previous behavior is untouched.This guarantees unchanged behavior for any previously implemented flow with this step.
Closes #CR-16035