Skip to content

adding support to pass git token directly to github-release step' #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 2, 2023
Merged

adding support to pass git token directly to github-release step' #560

merged 3 commits into from
Mar 2, 2023

Conversation

roi-codefresh
Copy link
Contributor

No description provided.

@roi-codefresh
Copy link
Contributor Author

roi-codefresh commented Mar 2, 2023 •
edited
Loading

I added a new argument to the step called git_token. Now if forbidDecrypt feature is enabled I catch the error when we try to get the token from the git context and print the following warning:
image

@roi-codefresh
Copy link
Contributor Author

roi-codefresh commented Mar 2, 2023 •
edited
Loading

Now this works:
image

@roi-codefresh roi-codefresh merged commit 08e1800 into master Mar 2, 2023
@noam-codefresh noam-codefresh deleted the CR-17430 branch November 2, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@danielm-codefresh danielm-codefresh danielm-codefresh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roi-codefresh @danielm-codefresh