version 1.1.0 #577
Merged
version 1.1.0 #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove subfolder in S3 bucket for build ID Adding IMAGE NAME and VERSION for easier testing Make script executable Make non public Add parameter for integration name Signed-off-by: Laurent Rochette <laurent.rochette@codefresh.io>
Signed-off-by: Laurent Rochette <laurent.rochette@codefresh.io>
Adding SA support Catching error when upload fails so step errors out
lrochette
requested review from
francisco-cocozza,
eti-codefresh,
ThatAmatoGuy and
dustinvanbuskirk
ThatAmatoGuy
approved these changes
Apr 27, 2023
incubating/aws-s3/step.yaml
Outdated
| "properties": | ||
| { | ||
| "S3_INTEGRATION": { | ||
| "type": "string", | ||
| "description": "The name of the S3 storage integration" | ||
| "description": "The name of the S3 storage integration fi you do not use a Service Account. if a SA exists, it will be used instead" |
There was a problem hiding this comment.
you have fi instead of if
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Service account support
Catching error when upload fails so step can error out
misc. spelling fixes