Skip to content

Conversation

noam-codefresh
Copy link
Contributor

What

added an initContainer to the runner, that creates the agent+runtime on the platform side, if there is no agent_codefresh_token available.

Why

will remove the requirement to run codefresh runner init --generate-helm-values-file before installing using helm.

Notes

the user will need to supply their codefresh token, as well as agent + runtime names, and context:

monitor:
  enabled: true

global:
  # codefreshHost: https://g.codefresh.io"
  codefreshToken: <TOKEN>
  accountId: <ACCOUNT_ID> # TODO: remove that
  agentName: some-agent
  runtimeName: some-rt
  context: <KUBE_CONTEXT>

@noam-codefresh noam-codefresh requested a review from a team as a code owner August 21, 2023 14:23
@noam-codefresh noam-codefresh self-assigned this Aug 21, 2023
@mikhail-klimko mikhail-klimko changed the title added runner init-container feat: add runner init-container; deprecate --generate-helm-values-file Aug 28, 2023
Copy link

@korenyoni korenyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small nitpick

@mikhail-klimko mikhail-klimko merged commit 132c333 into release-1.0 Aug 28, 2023
@mikhail-klimko mikhail-klimko deleted the CR-16346-venona-helm branch August 28, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants