Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature / add consentManager Placeholder component #232

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

enguerranws
Copy link
Collaborator

@enguerranws enguerranws commented Feb 6, 2024

I added the consentManager's Placeholder component based on the example given on the stories.

While adding the consent manager on our project, the CI failed on accessbility tests (aXe). I took the liberty to add titleAs so we have not to stick to arbitrary H levels on the DSFR examples (which are, depending on the context, accessibility issues):

  • replaced consentManager title by span, which won't break title hierarchy
  • Placeholder title with titleAs prop (which default to h4 - same behavior as the dsfr demo)
  • replaced consentManager modal wrapper tag by dialog (instead of div, to resolve missing landmarks issues)

Still discussing on it on Mattermost: https://mattermost.incubateur.net/betagouv/threads/jnzhstsadbdjib9ithqhotte7h

@enguerranws enguerranws force-pushed the feature/add-consent-manager-placeholder branch from 46811fa to 642b60d Compare February 6, 2024 09:18
@enguerranws enguerranws changed the title add consentManager Placeholder component, proposal for accessibility issues on titles and wrapper tags Feature / add consentManager Placeholder component Feb 6, 2024
@enguerranws enguerranws marked this pull request as draft February 6, 2024 09:20
@enguerranws enguerranws marked this pull request as ready for review February 6, 2024 09:36
@enguerranws enguerranws marked this pull request as draft February 6, 2024 09:41
@enguerranws
Copy link
Collaborator Author

Still having issues:

  • dialog seems to applies other styles (centered, thick border)
  • cookies banner and consent management modal have the same ID

I think I'll remove all semantic / accessbility related things in another PR.

@enguerranws enguerranws force-pushed the feature/add-consent-manager-placeholder branch from 642b60d to 0ddfff6 Compare February 6, 2024 09:56
@enguerranws enguerranws marked this pull request as ready for review February 6, 2024 15:31
@garronej
Copy link
Collaborator

garronej commented Feb 7, 2024

Let me know when you want me to review it!
And thanks a lot fot this!

@enguerranws
Copy link
Collaborator Author

@garronej feel free to review it :)

@garronej
Copy link
Collaborator

garronej commented Feb 8, 2024

Looks great, thanks a lot!

@garronej
Copy link
Collaborator

garronej commented Feb 8, 2024

<3

@garronej garronej merged commit 43747ea into main Feb 8, 2024
6 checks passed
@garronej garronej deleted the feature/add-consent-manager-placeholder branch February 8, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants