-
Notifications
You must be signed in to change notification settings - Fork 83
Feature/select with options prop #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Joseph Garrone <joseph.garrone.gj@gmail.com>
…emo project, fixed event.target.value type
Signed-off-by: Joseph Garrone <joseph.garrone.gj@gmail.com>
No action required, We'll se next peer prog session, I just leave the screenshot here as a reminder. |
Oh, I think it's caused by the placeholder, WE should use an empty string as a value if there's a placeholder instead of setting selected prop |
I'm using a local copy of the component in the SILL so that I can battle proff it before the release: https://github.com/codegouvfr/sill-web/blob/main/src/ui/shared/SelectNext.tsx |
Signed-off-by: Joseph Garrone <joseph.garrone.gj@gmail.com>
I merge as SelectNext since this select is already much better that the current one but we should schedule a session to finish it. |
Hi @enguerranws,
Follow up (yet again) of #76.
I merget but I rebased again, I spent another hour or so testing and improving the documentation and I realized that there is still quite a lot of work on this.
Curently there are a lot of way the component can be used that will led to inconsistent state.
There's also some undocumented behaviour.
Plus we haven't writen any tests to make sure users don't get red squigly lines when integrating with form libaries.
The curent implementation (on main) dosen't provide any typesafety but at least it makes it clear to the user that it's just a wrapper arount a default
<select />
.With this branch, we give a false sense of security witch is worse.
This PR has potential to improve things but it needs more work. I'd say at least 2hours, maybe more.
Let's schedule another peer programing session.