Enable warnings during spec execution and fix warnings

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2016-12-21 15:49:54 +0000 using RuboCop version 0.42.0.
+# on 2016-12-21 20:00:37 +0000 using RuboCop version 0.42.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -9,7 +9,7 @@
 # Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 108
+  Max: 109
 
 # Offense count: 89
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes.

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 * [#105](https://github.com/codegram/hyperclient/pull/105), [#108](https://github.com/codegram/hyperclient/pull/108): Added Danger, PR linter - [@dblock](https://github.com/dblock).
 * [#109](https://github.com/codegram/hyperclient/pull/109): Allow disabling asynchronous behavior per-instance - [@Talkdesk](https://github.com/Talkdesk).
+* [#110](https://github.com/codegram/hyperclient/pull/110): Fixed ruby warnings - [@ivoanjo](https://github.com/ivoanjo).
 * Your contribution here.
 
 ### 0.8.1 (March 15, 2016)

Rakefile

@@ -29,6 +29,7 @@ Rake::TestTask.new(:test) do |t|
   t.libs << 'test'
   t.pattern = 'test/**/*_test.rb'
   t.verbose = false
+  t.warning = true
 end
 
 desc 'runs the whole spinach suite'

lib/hyperclient.rb

@@ -1,4 +1,11 @@
+require 'hyperclient/collection'
+require 'hyperclient/link'
+require 'hyperclient/attributes'
+require 'hyperclient/curie'
 require 'hyperclient/entry_point'
+require 'hyperclient/link_collection'
+require 'hyperclient/resource'
+require 'hyperclient/resource_collection'
 require 'hyperclient/version'
 
 # Public: Hyperclient namespace.

lib/hyperclient/attributes.rb

@@ -1,5 +1,3 @@
-require 'hyperclient/collection'
-
 module Hyperclient
   # Public: A wrapper class to easily acces the attributes in a Resource.
   #

lib/hyperclient/curie.rb

@@ -1,5 +1,3 @@
-require 'hyperclient/resource'
-
 module Hyperclient
   # Internal: Curies are named tokens that you can define in the document and use
   # to express curie relation URIs in a friendlier, more compact fashion.

lib/hyperclient/entry_point.rb

@@ -1,4 +1,3 @@
-require 'hyperclient/link'
 require 'faraday_middleware'
 require 'faraday_hal_middleware'
 require_relative '../faraday/connection'
@@ -31,7 +30,7 @@ class EntryPoint < Link
     extend Forwardable
 
     # Public: Delegates common methods to be used with the Faraday connection.
-    def_delegators :connection, :basic_auth, :digest_auth, :token_auth, :headers, :headers=, :params, :params=
+    def_delegators :connection, :basic_auth, :digest_auth, :token_auth, :params, :params=
 
     # Public: Initializes an EntryPoint.
     #
@@ -40,6 +39,7 @@ def initialize(url, &_block)
       @link = { 'href' => url }
       @entry_point = self
       @options = { async: true }
+      @connection = nil
       yield self if block_given?
     end
 

lib/hyperclient/link.rb

@@ -1,4 +1,3 @@
-require 'hyperclient/resource'
 require 'uri_template'
 require 'futuroscope'
 
@@ -18,6 +17,7 @@ def initialize(key, link, entry_point, uri_variables = nil)
       @link          = link
       @entry_point   = entry_point
       @uri_variables = uri_variables
+      @resource      = nil
     end
 
     # Public: Indicates if the link is an URITemplate or a regular URI.

lib/hyperclient/link_collection.rb

@@ -1,7 +1,3 @@
-require 'hyperclient/collection'
-require 'hyperclient/link'
-require 'hyperclient/curie'
-
 module Hyperclient
   # Public: A wrapper class to easily acces the links in a  Resource.
   #

lib/hyperclient/resource.rb

@@ -1,7 +1,4 @@
 require 'forwardable'
-require 'hyperclient/attributes'
-require 'hyperclient/link_collection'
-require 'hyperclient/resource_collection'
 
 module Hyperclient
   # Public: Represents a resource from your API. Its responsability is to

lib/hyperclient/resource_collection.rb

@@ -1,6 +1,3 @@
-require 'hyperclient/collection'
-require 'hyperclient/resource'
-
 module Hyperclient
   # Public: A wrapper class to easily acces the embedded resources in a
   # Resource.

test/hyperclient/attributes_test.rb

@@ -1,5 +1,5 @@
 require_relative '../test_helper'
-require 'hyperclient/attributes'
+require 'hyperclient'
 
 module Hyperclient
   describe Attributes do

test/hyperclient/collection_test.rb

@@ -1,5 +1,5 @@
 require_relative '../test_helper'
-require 'hyperclient/resource'
+require 'hyperclient'
 
 module Hyperclient
   describe Collection do

test/hyperclient/curie_test.rb

@@ -1,6 +1,5 @@
 require_relative '../test_helper'
-require 'hyperclient/curie'
-require 'hyperclient/entry_point'
+require 'hyperclient'
 
 module Hyperclient
   describe Curie do

test/hyperclient/entry_point_test.rb

@@ -1,5 +1,5 @@
 require_relative '../test_helper'
-require 'hyperclient/entry_point'
+require 'hyperclient'
 
 module Hyperclient
   describe EntryPoint do

test/hyperclient/link_collection_test.rb

@@ -1,5 +1,5 @@
 require_relative '../test_helper'
-require 'hyperclient/link_collection'
+require 'hyperclient'
 
 module Hyperclient
   describe LinkCollection do

test/hyperclient/link_test.rb

@@ -1,6 +1,5 @@
 require_relative '../test_helper'
-require 'hyperclient/link'
-require 'hyperclient/entry_point'
+require 'hyperclient'
 
 module Hyperclient
   describe Link do

test/hyperclient/resource_collection_test.rb

@@ -1,5 +1,5 @@
 require_relative '../test_helper'
-require 'hyperclient/resource_collection'
+require 'hyperclient'
 
 module Hyperclient
   describe ResourceCollection do

test/hyperclient/resource_test.rb

@@ -1,5 +1,5 @@
 require_relative '../test_helper'
-require 'hyperclient/resource'
+require 'hyperclient'
 
 module Hyperclient
   describe Resource do