Drop the turn dependency #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki24
commented
Aug 23, 2019
|
|
||
| resource.foos._embedded.orders.first.id.must_equal 1 | ||
| resource.foos.first.must_equal nil | ||
| resource.foos.first.must_be_nil |
There was a problem hiding this comment.
must_equal nil would cause:
DEPRECATED: Use assert_nil if expecting nil from /Users/yuki/GitHub/hyperclient/test/hyperclient/link_test.rb:304. This will fail in Minitest 6.
Here's an example of a CHANGELOG.md entry: * [#145](https://github.com/codegram/hyperclient/pull/145): Drop the turn dependency - [@yuki24](https://github.com/yuki24).Generated by 🚫 Danger |
yuki24
commented
Aug 23, 2019
| @@ -1,12 +1,11 @@ | |||
| $LOAD_PATH << 'lib' | |||
|
|
|||
| require 'minitest/spec' | |||
There was a problem hiding this comment.
This causes a circular dependency error:
/Users/yuki/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/minitest-5.11.3/lib/minitest.rb:987: warning: /Users/yuki/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/minitest-5.11.3/lib/minitest.rb:987: warning: loading in progress, circular require considered harmful - /Users/yuki/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/minitest-5.11.3/lib/minitest/test.rb
from /Users/yuki/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.3/lib/rake/rake_test_loader.rb:5:in `<main>'
from /Users/yuki/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.3/lib/rake/rake_test_loader.rb:5:in `select'
from /Users/yuki/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.3/lib/rake/rake_test_loader.rb:17:in `block in <main>'
from /Users/yuki/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.3/lib/rake/rake_test_loader.rb:17:in `require'
from /Users/yuki/GitHub/hyperclient/test/faraday/connection_test.rb:1:in `<top (required)>'
from /Users/yuki/GitHub/hyperclient/test/faraday/connection_test.rb:1:in `require_relative'
from /Users/yuki/GitHub/hyperclient/test/test_helper.rb:3:in `<top (required)>'
from /Users/yuki/GitHub/hyperclient/test/test_helper.rb:3:in `require'
from /Users/yuki/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/minitest-5.11.3/lib/minitest/spec.rb:1:in `<top (required)>'
from /Users/yuki/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/minitest-5.11.3/lib/minitest/spec.rb:1:in `require'
from /Users/yuki/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/minitest-5.11.3/lib/minitest/test.rb:1:in `<top (required)>'
from /Users/yuki/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/minitest-5.11.3/lib/minitest/test.rb:1:in `require'
from /Users/yuki/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/minitest-5.11.3/lib/minitest.rb:987:in `<top (required)>'
from /Users/yuki/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/minitest-5.11.3/lib/minitest.rb:987:in `require'
And it seems like this is unnecessary now, so just removing it.
What's up with this one? I can debug later. The |
|
Not sure what's going on with Danger. Maybe we can drop the following entirely? Lines 10 to 12 in 9528554 |
|
Rebase against master, #146 fixes the danger issues. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the
terngem is no longe maintained and I couldn't run the test suite after "bundle update", becauseTurnthinks that minitest 5.11.3 is out of date even though it is the latest one:The latest version of
turnhas a constraint on the minitest gem~> 4, which is more than 5 years old. I don't think we should use that. As a replacement I just addedrequire 'minitest/pride'to make it a little colorful.Here is a screenshot of the output from the new setup: