Added _curies support. #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
force-pushed
the
curies-support
branch
2 times, most recently
from
cbd5bba
to
c9ae7ce
Compare
|
Maybe you could add a note to the README so everyone knows that Hyperclient has curie support now :) Anyway 👍, great job. |
dblock
force-pushed
the
curies-support
branch
from
c9ae7ce
to
37f386a
Compare
dblock
force-pushed
the
curies-support
branch
from
37f386a
to
44d106b
Compare
|
Good point about docs, done. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curies get attached to
LinkCollectionsince that's where they appear and matter, and then used to expand links. Open to refactoring this in some different way.Expanding a curie is as simple as replacing
{rel}in the curie's href by the URL, unless I am missing something.URITemplatewould encode the URL if you saidexpand(rel: href), so I got stuck with agsub. I could be wrong and there's a better way to do this.