wasm #25
Draft
wasm #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alun
reviewed
Oct 21, 2019
| let start = null; | ||
|
|
||
| const handleStats = timestamp => { | ||
| const elapsedTime = timestamp - start; |
There was a problem hiding this comment.
shouldn't this have if (start == null) { start = timestamp; return; } ?
alun
reviewed
Oct 21, 2019
| const elapsedTime = timestamp - start; | ||
| start = timestamp; | ||
| decrease_stats(stats, elapsedTime / 1000); | ||
| stats = stats; // pffffff |
There was a problem hiding this comment.
Svelte's neatness? Maybe rewriting as:
stats = decrease_stats(stats, elapsedTime / 1000);
would make it less weird
There was a problem hiding this comment.
Unfortunately this won't work because decrease_stats doesn't return the stats, since it's a borrowed reference and AFAIK it's not possible at the moment to do that with wasm-bindgen.
Anyway, this was just to try out wasm, I'm not gonna move forward with this at least for a few months (too much unsupported stuff). Thanks for your comments though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
svelte + wasm because why not 🤯