Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PlexusIoZipFileResourceCollection with PlexusArchiverZipFileResourceCollection #90

Open
plamentotev opened this issue May 27, 2018 · 2 comments

Comments

@plamentotev
Copy link
Member

plamentotev commented May 27, 2018

Currently for ZIP files PlexusArchiverZipFileResourceCollection is used and PlexusIoZipFileResourceCollection for the rest of the ZIP based file formats (Jar, War, etc). Apart from being inconsistent, there is performance penalty for using PlexusIoZipFileResourceCollection (see codehaus-plexus/plexus-io#12).

According to this comment there are integration tests in Maven Assembly plugin failing when PlexusArchiverZipFileResourceCollection is used for all formats.

Does anybody knows what the issues with PlexusArchiverZipFileResourceCollection are (if there are any - there were some bugs fixed since)? /cc @krosenvold

@plamentotev
Copy link
Member Author

Actually I ran the ITs in Maven Assembly(on Windows) and none of them is failing when PlexusIoZipFileResourceCollection is replaced with PlexusArchiverZipFileResourceCollection.

@plamentotev
Copy link
Member Author

As @slachiewicz pointed out (codehaus-plexus/plexus-io#12 (comment)) PlexusIoZipFileResourceCollection verifies the signatures of the Jar files (if signed). PlexusArchiverZipFileResourceCollection does not so just switching the implementations would not work. We can create another resource collection for Jar based file format that will verify the signatures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant