Skip to content

check minimum timestamp: avoid negative Zip 5455 Extended Timestamp #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
Merged

check minimum timestamp: avoid negative Zip 5455 Extended Timestamp #388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/main/java/org/codehaus/plexus/archiver/zip/AbstractZipArchiver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,14 @@ protected FileTime normalizeLastModifiedTime(FileTime lastModifiedTime) {
*/
private static long dosToJavaTime(long dosTime) {
Calendar cal = Calendar.getInstance(TimeZone.getDefault(), Locale.ROOT);
if (dosTime < MIN_DOS_JAVA_TIME) {
dosTime = MIN_DOS_JAVA_TIME;
}
cal.setTimeInMillis(dosTime);
return dosTime - (cal.get(Calendar.ZONE_OFFSET) + cal.get(Calendar.DST_OFFSET));
}

// minimum DOS time that will give a positive Java time, whatever the current TZ is:
// biggest TZ offset is for Etc/GMT-14 https://en.wikipedia.org/wiki/List_of_tz_database_time_zones
private static final long MIN_DOS_JAVA_TIME = 1000 * 14 * 3600;
}
Loading