Skip to content

Issue #111 - Refactor and add unit tests for support for multiple --add-exp… #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 30, 2020
Merged

Issue #111 - Refactor and add unit tests for support for multiple --add-exp… #113

merged 2 commits into from
Dec 30, 2020

Conversation

eilensm
Copy link
Contributor

@eilensm eilensm commented Dec 6, 2020

…orts custom compiler arguments

This is my first PR and I hope I got everything right so far...

@eilensm eilensm mentioned this pull request Dec 17, 2020
Closed
tomaswolf
tomaswolf approved these changes Dec 19, 2020
View reviewed changes
Copy link
Contributor

@tomaswolf tomaswolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tomaswolf
Copy link
Contributor

@olamy could you take a look and merge if OK?

@olamy olamy merged commit 9a380f6 into codehaus-plexus:master Dec 30, 2020
@tomaswolf
Copy link
Contributor

Thank you!

@olamy
Copy link
Member

olamy commented Dec 30, 2020

no worries. really sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@tomaswolf tomaswolf tomaswolf approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eilensm @tomaswolf @olamy