FileUtils can never throw an IOException

[bmarwell]

Hi,

I did a quick check of FileUtils::getFileAndDirectoryNames

Signature:

public static List<String> getFileAndDirectoryNames( File directory, String includes, String excludes,
                                                         boolean includeBasedir, boolean isCaseSensitive,
                                                         boolean getFiles, boolean getDirectories )
        throws IOException;

Source:

plexus-utils/src/main/java/org/codehaus/plexus/util/FileUtils.java

Lines 1833 to 1906 in 1f93cc8

	/**
	* Return a list of files as String depending options.
	*
	* @param directory the directory to scan
	* @param includes the includes pattern, comma separated
	* @param excludes the excludes pattern, comma separated
	* @param includeBasedir true to include the base dir in each String of file
	* @param isCaseSensitive true if case sensitive
	* @param getFiles true if get files
	* @param getDirectories true if get directories
	* @return a list of files as String
	* @throws IOException io issue
	*/
	public static List<String> getFileAndDirectoryNames( File directory, String includes, String excludes,
	boolean includeBasedir, boolean isCaseSensitive,
	boolean getFiles, boolean getDirectories )
	throws IOException
	{
	DirectoryScanner scanner = new DirectoryScanner();
	scanner.setBasedir( directory );
	if ( includes != null )
	{
	scanner.setIncludes( StringUtils.split( includes, "," ) );
	}
	if ( excludes != null )
	{
	scanner.setExcludes( StringUtils.split( excludes, "," ) );
	}
	scanner.setCaseSensitive( isCaseSensitive );
	scanner.scan();
	List<String> list = new ArrayList<String>();
	if ( getFiles )
	{
	String[] files = scanner.getIncludedFiles();
	for ( String file : files )
	{
	if ( includeBasedir )
	{
	list.add( directory + FileUtils.FS + file );
	}
	else
	{
	list.add( file );
	}
	}
	}
	if ( getDirectories )
	{
	String[] directories = scanner.getIncludedDirectories();
	for ( String directory1 : directories )
	{
	if ( includeBasedir )
	{
	list.add( directory + FileUtils.FS + directory1 );
	}
	else
	{
	list.add( directory1 );
	}
	}
	}
	return list;
	}

It seems it can never throw an IOException.
If we removed it, a lot of Maven Mojos could be made MUCH simpler.

One of the reasons is that canGenerateReport is called both in execute and executeReport. One throws a MojoExecutionException, the other one a MavenReportException, but canGenerateReport can throw neither. This means, that it is impossible to deal with IOExceptions in Maven Reports anyway.

[slachiewicz]

all inside FileUtils needs cleanup and move directly to NIO

[michael-o]

all inside FileUtils needs cleanup and move directly to NIO

If the wrapper is thin, then I would even prefer to throw it away.

[bmarwell]

Yes, it is just Files.walk essentially.

[elharo]

Yes, please deprecate all of this. It's a remnant of a time when the Java class library was much less powerful than it has been for the last ten years. If we were starting over, this wouldn't be needed.

[michael-o]

https://issues.apache.org/jira/browse/MSHARED-1032

[slachiewicz]

so with MSHARED-1032 implemented - this issue is no longer valid?

[bmarwell]

Yep.