Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provides a CachingOuptutStream and a CachingWriter #184

Merged
merged 8 commits into from Apr 26, 2022

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Feb 21, 2022

olamy
olamy approved these changes Feb 22, 2022
@gnodet gnodet requested a review from olamy Feb 22, 2022
@gnodet
Copy link
Contributor Author

gnodet commented Apr 26, 2022

@olamy @michael-o @cstamas could one of you squash/merge this PR ? I don't have any karma to do it.

@michael-o
Copy link
Member

michael-o commented Apr 26, 2022

@olamy @michael-o @cstamas could one of you squash/merge this PR ? I don't have any karma to do it.

Interactive rebase does not work for you in the terminal?

@gnodet
Copy link
Contributor Author

gnodet commented Apr 26, 2022

@olamy @michael-o @cstamas could one of you squash/merge this PR ? I don't have any karma to do it.

Interactive rebase does not work for you in the terminal?

I suppose it does, however, I can't push to the codehaus-plexus repositories as I'm not a member of this org. So it's more about the merge part than the squash ;-)

@cstamas cstamas merged commit 49773f1 into codehaus-plexus:master Apr 26, 2022
22 checks passed
@cstamas
Copy link
Member

cstamas commented Apr 26, 2022

@gnodet seems merged code UT failed?

@gnodet
Copy link
Contributor Author

gnodet commented Apr 26, 2022

Weird, that's the one I fixed with 0c03b46

@gnodet
Copy link
Contributor Author

gnodet commented Apr 26, 2022

So the test is flaky under linux. I'll provide a PR to make it more robust or fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants