#51: PrettyPrintXMLWriter fails with a java.util.NoSuchElementException (Java 1.7 only) #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Java 1.7 only) Changed concatenation expression in endElement() method to avoid the Java 7 bug. Added test to detect if the bug is present.
rfscholte
reviewed
Dec 1, 2018
| // TODO: change the below code to a more efficient expression when the library | ||
| // be ready to target Java 8. | ||
| String element = elementStack.removeLast(); | ||
| write( "</" + element + ">" ); |
There was a problem hiding this comment.
Nice unittest! This also confirms that the following works too:
write( "</" );
write( elementStack.removeLast() );
write( ">" );
I prefer this, since it removes the variable creation and assignment explicitly.
There was a problem hiding this comment.
The comment is now out of sync, i.e.
removed the element into a variable first
:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed concatenation expression in endElement() method to avoid the Java 7 bug.
Added test to detect if the bug is present.