Skip to content

docs: added twitter profile header example #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 29, 2023

Conversation

e-younan
Copy link
Member

Description

This PR introduces a new example in the example project. In this new example, we implement the Twitter profile header using this library.

Motivation and Context

The reasoning behind adding this example is two-fold:

  1. Add a more complex use case for developers to reference from
  2. Observe the shortcomings of the library implementation to look for improvements.

How Has This Been Tested?

This implementation doesn't affect the library, so no testing is required. However, please note that this has only been tested heavily on iOS - Android has a bug that I have observed, but I will fix that in a future PR.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have followed the guidelines in the README.md file.
  • I have updated the documentation as necessary.
  • My changes generate no new warnings.

Screenshots

twitter-header.mov

Additional Notes

A blog post around the implementation is in the works. Stay tuned!

@e-younan e-younan merged commit 3c3a264 into main Mar 29, 2023
@e-younan e-younan deleted the example/twitter-profile-nav branch March 29, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant