Skip to content

Decouple Groups' bounds from their position to fix anchoring issues #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 12, 2022
Merged

Decouple Groups' bounds from their position to fix anchoring issues #142

merged 3 commits into from
Apr 12, 2022

Conversation

anderoonies
Copy link
Contributor

@anderoonies anderoonies commented Apr 10, 2022 •
edited
Loading

Fixes #141

Summary

#141 describes the bug, but Groups' bounds were tied to their position, which meant that the bounding box displayed incorrectly.

Changes:

  • Introduce internal _minX and _minY to a Group, which stores its top left corner, which is used to position it

Screenshots of the change:

image

Checklist

  • npm test passes
  • Unit tests are included / updated
  • Documentation has been updated where relevant

@anderoonies anderoonies changed the title WIP Group bounds fix. Fixes #141 Decouple Groups' bounds from their position to fix anchoring issues Apr 12, 2022
@anderoonies anderoonies merged commit cf0777e into codehs:main Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Groups' bounding boxes when .debug = true are incorrect when anchored
1 participant
@anderoonies