Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev: use Superglobals service and remove superglobals #7866

Open
kenjis opened this issue Aug 26, 2023 · 1 comment
Open

Dev: use Superglobals service and remove superglobals #7866

kenjis opened this issue Aug 26, 2023 · 1 comment
Labels
dev

Comments

@kenjis
Copy link
Member

kenjis commented Aug 26, 2023

Use Services::superglobals() and remove all superglobals ($_SERVER, $_GET) in the code base (except in the Superglobals class).

CodeIgniter4/system/Config/Services.php

Line 723 in 60b22bf

public static function superglobals(

CodeIgniter4/system/Superglobals.php

Line 19 in 60b22bf

final class Superglobals

@kenjis kenjis added the dev label Aug 26, 2023
@paulbalandan
Copy link
Member

This is a good phpstan rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kenjis @paulbalandan