Skip to content

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 2, 2023

Description
See https://forum.codeigniter.com/showthread.php?tid=86536&pid=406349#pid406349

If "Allowed memory size of xxx bytes exhausted" error occurs in the Exception handler,
the true Exception does not show in the debug stack trace.

This PR is not perfect, but DX would be improved.

Before:
Screenshot 2023-02-02 13 29 05

After:
Screenshot 2023-02-02 at 13-29-41 ErrorException

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Feb 2, 2023
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an improvement.

@kenjis kenjis merged commit 55a5527 into codeigniter4:develop Feb 7, 2023
@kenjis kenjis deleted the fix-exception-stacktrace branch February 7, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants