Skip to content

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Aug 28, 2025

Description
See #9664

Reference : https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_arrayobject_and_arrayiterator_with_objects

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr added refactor Pull requests that refactor code 4.7 labels Aug 28, 2025
@samsonasik
Copy link
Member

Looking from mobile, $this->cookies seems array, so it indirect object fill, which should be ok, the deprecated is only on direct object fill.

@michalsn
Copy link
Member

Yes, it seems I overlooked that - sorry.

@paulbalandan
Copy link
Member

I agree with @samsonasik. The deprecation is only for objects used directly like an array causing to iterate on that object's properties. In this case, this is iterating over a collection of Cookie objects so won't be a problem.

@michalsn
Copy link
Member

Totally my fault, since I listed this in #9664. Sorry @ddevsr for wasting your time.

@michalsn michalsn closed this Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.7 refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants