Skip to content

fix: cannot read properties of null in toggleViewsHints (toolbar.js) #9736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2025
Merged

fix: cannot read properties of null in toggleViewsHints (toolbar.js) #9736

merged 1 commit into from
Oct 3, 2025

Conversation

michalsn
Copy link
Member

@michalsn michalsn commented Oct 1, 2025

Description
This PR fixes an Uncaught TypeError: Cannot read properties of null in toolbar.js within the toggleViewsHints method.

Fixes #9726

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn added the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 3, 2025
@paulbalandan
Copy link
Member

Oh, this needs to update the conflict

@michalsn
Copy link
Member Author

michalsn commented Oct 3, 2025

Updated. Thank you @paulbalandan

@michalsn michalsn merged commit cd92eab into codeigniter4:develop Oct 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Crash in toggleViewsHints - getValidElementInner
2 participants
@michalsn @paulbalandan