Skip to content

Add support PHPUnit 10 #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 7, 2024
Merged

Add support PHPUnit 10 #130

merged 5 commits into from
May 7, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 28, 2024 •
edited
Loading

Description
CI 4.5.0 requires PHPUnit 10.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
Copy link
Member Author

kenjis commented May 6, 2024

Can someone review?

michalsn
michalsn approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but why leave PHPUnit 9 when version 10 is required for CI 4.5?

@michalsn
Copy link
Member

michalsn commented May 6, 2024

Doh... this is a devkit repo. All good.

@kenjis kenjis merged commit ef76508 into codeigniter4:develop May 7, 2024
@kenjis kenjis deleted the update-phpunit10 branch May 7, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn