Add an additional condition before reconnect()

[michalsn]

Description
This PR checks if the connection has been established before we call the reconnect() method.

When a connection to the database is lost, the $this->db->connID remains valid in terms of its existence, but the actual connection might be closed or invalid.

There are no actual tests for this because I don't know how I can test it - we have a valid DB connection during the tests. Although I confirmed this was a bug and this change fixes it.

Needs #46

Fixes #45

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[coveralls]

Pull Request Test Coverage Report for Build 10923540520

Details

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 87.433%

---

Totals
Change from base Build 10923488005:	0.0%
Covered Lines:	487
Relevant Lines:	557

---

💛 - Coveralls

[kenjis]

Isn't this a bug in the framework?
I think reconnect() should not cause the error.

[michalsn]

I'm not sure how to treat this.

The reconnect() method should only be used after the connection to the database has been established. It used to be that the connection was established immediately, but I think at some point we made a change so that it was only established when we wanted to use the connection (for the first time) - hence the possibility of an error.

I think it is better to show the error than to hide it. In the sense of silently omitting the reconnect() call - because that's what I think it would come down to in order to get around this problem on the framework side.

[kenjis]

When a connection to the database is lost, the $this->db->connID remains valid in terms of its existence, but the actual connection might be closed or invalid.

Does this PR fix the error when a connection to the database is lost?

[michalsn]

Does this PR fix the error when a connection to the database is lost?

Yes, because in that case $this->db->connID is not false.

[kenjis]

Okay. I got your opinion:

1. When the connection is already made (and lost), we should call reconnect().
2. When the connection is not made, we should not call reconnect(). (The DB connection connects automatically when needed).

[michalsn]

Thank you!