Skip to content

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Nov 15, 2021

Since we need to do a major release, might as well do this the right way :)

@lonnieezell
Copy link
Member

Also - Kenji mentioned fixing a bug in CI that might have been causing the namespace conflicts I saw that made me use Sparks for this. Probably can't change that yet, though since I don't think that's made it into a release yet, but it would be nice to use the CodeIgniter\Settings namespace. Oh, well, maybe next time.

@MGatner
Copy link
Member Author

MGatner commented Nov 15, 2021

@lonnieezell I haven't had any issues using other CodeIgniter namespaces (like for Cache and Tasks) so maybe whatever the issue was is something that is already fixed? I will give it a shot in a different PR.

@MGatner MGatner merged commit 43230fa into develop Nov 15, 2021
@MGatner MGatner deleted the service branch November 15, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants