Skip to content

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Nov 21, 2021

  • Allows for multiple write handlers during set() and forget()
  • Standardizes write method return expectations to void with expected exceptions

@MGatner
Copy link
Member Author

MGatner commented Nov 21, 2021

@lonnieezell See what you think. The returns of the various methods were not consistent, so rather than try to gather results from all write handler methods I decided to nix the return values and state the expectation that failures should throw. That's the only "breaking-ish" change but won't actually cause code failures since the return statement was only in the docblock (and void was already a possibility).

@MGatner MGatner requested a review from lonnieezell November 21, 2021 15:11
@MGatner MGatner linked an issue Nov 21, 2021 that may be closed by this pull request
@MGatner MGatner mentioned this pull request Nov 21, 2021
Copy link
Member

@lonnieezell lonnieezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a problem with this. And I don't consider an incorrect docblock to be BC in any shape :)

@MGatner MGatner merged commit 0c3fbd5 into develop Nov 22, 2021
@MGatner MGatner deleted the multiple-writes branch November 22, 2021 17:54
@MGatner MGatner added the enhancement New feature or request label Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Multiple Write Handlers

2 participants