Move the test namespace from Tests\ to CodeIgniter\Shield\Tests

[paulbalandan]

Shield's tests live under the Tests\ namespace. Some framework classes are marked @internal, and PHPStan only allows use of an internal class from inside its root namespace. The root for the framework is CodeIgniter, so tests under Tests\ are flagged for legitimate test hooks.

Impact today

service('superglobals') is the only way to set cookies and server values in tests on framework 4.4 and later. The framework snapshots superglobals, so writing $_COOKIE directly does not work. The 8 calls to Superglobals::setCookie(), setServer() and unsetServer() in SessionAuthenticatorTest, ActionsTest, LoginTest and MagicLinkTest are reported as method.internalClass and sit in phpstan-baseline.php. single_service() does not help, because PHPStan flags the namespace of the caller and not the way the object was obtained.

Verification

I moved one test class to CodeIgniter\Shield\Tests\…, removed @internal from the two abstract support classes (DatabaseTestCase and TestCase) and re-ran PHPStan. The Superglobals errors disappeared for that file.

Proposal

• Rename the 72 test classes from Tests\… to CodeIgniter\Shield\Tests\….
• Keep the support classes in Tests\Support\, as the framework does, and drop @internal from DatabaseTestCase and TestCase.
• Update the Tests\\ entry in autoload-dev and the AbstractFilterTestCase reference in pyrameter.php.

This mirrors how the framework names its own tests and removes the 8 baseline entries without an ignore rule.

[datamweb]

Good catch! You've identified the issue and come up with a good solution. This looks like a solid approach to me!

[paulbalandan]

Thanks. I'll come up with the PR.