-
Notifications
You must be signed in to change notification settings - Fork 144
fix: Exception structure #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It is not expected to catch these exceptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Your desired hierarchy would work if your PR to the framework for exception interfaces goes through. To that end we should consider making these exception classes @internal
or final
or both (which is probably a good idea anyway).
5a21fa2
to
63ca0af
Compare
So I removed
|
1898dc6
to
3eafffe
Compare
3eafffe
to
d8342dd
Compare
Just out of curiosity what is the advantage of implementing our own version if |
The reason for placing all exceptions under BaseException is to make it easier to know where the exception came from. It is the developer's responsibility to decide how to handle the exception. If a dev catches |
This PR changes the hierarchy of Exceptions for Shield as follows: