-
Notifications
You must be signed in to change notification settings - Fork 144
Add previousLogin method #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kenjis
merged 8 commits into
codeigniter4:develop
from
sammyskills:add-previous-login-method
Jul 24, 2022
Merged
Add previousLogin method #301
kenjis
merged 8 commits into
codeigniter4:develop
from
sammyskills:add-previous-login-method
Jul 24, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you add test code? |
kenjis
reviewed
Jul 17, 2022
MGatner
requested changes
Jul 18, 2022
You have a coding style violation. 1) shield/tests/Unit/UserTest.php (no_whitespace_in_blank_line)
---------- begin diff ----------
--- /home/runner/work/shield/shield/tests/Unit/UserTest.php
+++ /home/runner/work/shield/shield/tests/Unit/UserTest.php
@@ -111,7 +111,7 @@
// No logins found.
$this->assertNull($this->user->previousLogin());
-
+
fake(
LoginModel::class,
['id_type' => 'email', 'identifier' => $this->user->email, 'user_id' => $this->user->id]
----------- end diff ----------- |
kenjis
reviewed
Jul 18, 2022
kenjis
reviewed
Jul 19, 2022
kenjis
reviewed
Jul 19, 2022
kenjis
reviewed
Jul 19, 2022
kenjis
requested changes
Jul 19, 2022
kenjis
approved these changes
Jul 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
MGatner
approved these changes
Jul 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a method to get the previous login record of a user, useful for displaying to the user, the last time the account was accessed.