Skip to content

Conversation

datamweb
Copy link
Collaborator

No description provided.

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@MGatner MGatner merged commit a8eb256 into codeigniter4:develop Jul 25, 2022
@datamweb datamweb deleted the fix-phpdocs-action-type branch July 25, 2022 19:22
$authenticator->startLogin($user);

// If an action has been defined for login, start it up.
// If an action has been defined for register, start it up.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@datamweb It is not phpDoc. Just a comment.
PHPDocs must start with /** and end with */.
See https://www.php.net/manual/en/reflectionclass.getdoccomment.php

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kenjis , I am an electrical engineer. I became interested in PHP many years ago and tried to learn it.
During this time, your presence made me move from a static state to a forward state in programming.
I thank you very much.
And I'm sorry that I usually surprise you.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not particularly surprising!
It is hard to imagine that there is a special comment style called Doc comment.

@datamweb datamweb changed the title phpDocs: modify the action type fix: modify the action type in comment Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants