-
Notifications
You must be signed in to change notification settings - Fork 144
fix: MySQL tests #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: MySQL tests #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
commented
Aug 3, 2022
4 tasks
MGatner
requested changes
Aug 3, 2022
User::$id should be 1, not '1'.
We don't need a user recored for the current SessionAuthenticatorTest.
$ composer test
> phpunit
PHPUnit 9.5.21 #StandWithUkraine
Runtime: PHP 8.0.21
Configuration: /Users/kenji/work/codeigniter/codeigniter-shield/phpunit.xml
Random Seed: 1659602347
............................................................... 63 / 225 ( 28%)
............................................................... 126 / 225 ( 56%)
............................................................... 189 / 225 ( 84%)
.................................... 225 / 225 (100%)
Nexus\PHPUnit\Extension\Tachycardia identified these 30 slow tests:
+--------------------------------------------------------------------------------------------+---------------+-------------+
| Test Case | Time Consumed | Time Limit |
+--------------------------------------------------------------------------------------------+---------------+-------------+
| Tests\\Controllers\\RegisterTest::testRegisterActionSuccess | 00:00:02.40 | 00:00:00.50 |
| Tests\\Controllers\\LoginTest::testLoginRedirectsToActionIfDefined | 00:00:02.29 | 00:00:00.50 |
| Tests\\Controllers\\RegisterTest::testRegisterRedirectsToActionIfDefined | 00:00:02.16 | 00:00:00.50 |
| Tests\\Unit\\UserTest::testPreviousLogin | 00:00:02.11 | 00:00:00.50 |
| Tests\\Authorization\\AuthorizableTest::testCanCascadesToGroupsWithWildcards | 00:00:01.64 | 00:00:00.50 |
| Tests\\Unit\\UserModelTest::testUpdateUserObjectWithoutUserDataToUpdate | 00:00:01.48 | 00:00:00.50 |
| Tests\\Authentication\\MagicLinkTest::testMagicLinkSubmitSuccess | 00:00:01.25 | 00:00:00.50 |
| Tests\\Unit\\UserModelTest::testSaveInsertUser | 00:00:01.24 | 00:00:00.50 |
| Tests\\Controllers\\LoginTest::testLogoutAction | 00:00:01.21 | 00:00:00.50 |
| Tests\\Authentication\\Filters\\ChainFilterTest::testFilterSuccessSeession | 00:00:01.21 | 00:00:00.50 |
| Tests\\Unit\\UserTest::testGetIdentitiesSome | 00:00:01.20 | 00:00:00.50 |
| Tests\\Unit\\DictionaryValidatorTest::testCheckTrueOnNotFound | 00:00:01.16 | 00:00:00.50 |
| Tests\\Authentication\\Authenticators\\AccessTokenAuthenticatorTest::testCheckOldToken | 00:00:01.15 | 00:00:00.50 |
| Tests\\Controllers\\LoginTest::testLoginActionEmailSuccess | 00:00:01.09 | 00:00:00.50 |
| Tests\\Controllers\\RegisterTest::testRegisterDisplaysForm | 00:00:01.08 | 00:00:00.50 |
| Tests\\Unit\\UserModelTest::testSaveUpdateUserObjectWithUserDataToUpdate | 00:00:01.05 | 00:00:00.50 |
| Tests\\Authentication\\Authenticators\\SessionAuthenticatorTest::testAttemptCannotFindUser | 00:00:01.05 | 00:00:00.50 |
| Tests\\Controllers\\LoginTest::testLoginActionUsernameSuccess | 00:00:01.04 | 00:00:00.50 |
| Tests\\Unit\\UserTest::testUpdatePasswordHash | 00:00:01.04 | 00:00:00.50 |
| Tests\\Authentication\\Authenticators\\SessionAuthenticatorTest::testAttemptUsernameOnly | 00:00:01.03 | 00:00:00.50 |
| Tests\\Unit\\UserTest::testModelfindAllWithIdentities | 00:00:01.03 | 00:00:00.50 |
| Tests\\Controllers\\MagicLinkTest::testAfterLoggedInNotAllowDisplayMagicLink | 00:00:01.00 | 00:00:00.50 |
| Tests\\Authorization\\AuthorizableTest::testAddPermissionWithNoExistingPermissions | 00:00:01.00 | 00:00:00.50 |
| Tests\\Controllers\\ActionsTest::testActionShowNoneAvailable | 00:00:00.99 | 00:00:00.50 |
| Tests\\Unit\\UserModelTest::testUpdateUserArrayWithUserDataToUpdate | 00:00:00.98 | 00:00:00.50 |
| Tests\\Unit\\UserTest::testModelfindByIdWithIdentities | 00:00:00.98 | 00:00:00.50 |
| Tests\\Unit\\UserTest::testGetIdentitiesByType | 00:00:00.95 | 00:00:00.50 |
| Tests\\Authentication\\Filters\\TokenFilterTest::testFilterSuccess | 00:00:00.95 | 00:00:00.50 |
| Tests\\Authentication\\MagicLinkTest::testMagicLinkSubmitNoEmail | 00:00:00.94 | 00:00:00.50 |
| Tests\\Authorization\\AuthorizableTest::testRemoveGroupNoGroups | 00:00:00.94 | 00:00:00.50 |
+--------------------------------------------------------------------------------------------+---------------+-------------+
...and 108 more tests hidden from view.
Time: 02:02.688, Memory: 42.00 MB
OK (225 tests, 513 assertions) |
MGatner
approved these changes
Aug 4, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #331 (comment)
integer
forUser::$id