Skip to content

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 12, 2022

No description provided.

@kenjis kenjis added the refactor Pull requests that refactor code label Aug 12, 2022
@datamweb
Copy link
Collaborator

@kenjis، in this PR, something else is going to be done?
If not please merge.

@kenjis
Copy link
Member Author

kenjis commented Aug 14, 2022

Nothing. But only MGater approved.

@datamweb
Copy link
Collaborator

datamweb commented Aug 14, 2022

If the BaseController.php is $this->helpers = array_merge($this->helpers, ['setting']);

Output :
Screenshot 2022-08-14 114856

I didn't like it!! Why repeat twice!

@kenjis
Copy link
Member Author

kenjis commented Aug 14, 2022

Because it checks the file twice.
$this->helpers = array_merge($this->helpers, ['auth', 'setting']); and
$this->helpers = array_merge($this->helpers, ['setting']);

It is not easy to show the message once.

@kenjis kenjis merged commit c48cb81 into codeigniter4:develop Aug 14, 2022
@kenjis kenjis deleted the autoload-helpers branch August 14, 2022 09:13
@kenjis kenjis mentioned this pull request Aug 14, 2022
@kenjis
Copy link
Member Author

kenjis commented Aug 14, 2022

@datamweb I was able to fix the repeated Skip messages. See #371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants