Skip to content

feat: update shield:setup for Security Setup #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 17, 2022
Merged

feat: update shield:setup for Security Setup #384

merged 6 commits into from
Aug 17, 2022

Conversation

datamweb
Copy link
Collaborator

@datamweb datamweb commented Aug 16, 2022 •
edited
Loading

Hello friends,
This PR gives command shield:setup the ability to automatically implement the security proposal issued in SecurityAdvisories.

@datamweb datamweb added the enhancement New feature or request label Aug 16, 2022
kenjis
kenjis reviewed Aug 16, 2022
View reviewed changes
MGatner
MGatner reviewed Aug 16, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a cool change! @kenjis has a better handle on the replacement system so I will leave those details, but I'm grateful for the work.

@datamweb datamweb added the tests needed Pull requests that need tests label Aug 17, 2022
@datamweb datamweb marked this pull request as draft August 17, 2022 05:29
@datamweb datamweb force-pushed the update-shield-setup-command branch from 934613c to d198764 Compare August 17, 2022 07:22
@datamweb datamweb marked this pull request as ready for review August 17, 2022 07:48
@datamweb datamweb requested a review from kenjis August 17, 2022 07:48
@datamweb datamweb removed the tests needed Pull requests that need tests label Aug 17, 2022
MGatner
MGatner approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please await @kenjis' final review.

kenjis
kenjis reviewed Aug 17, 2022
View reviewed changes
kenjis
kenjis approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@kenjis kenjis merged commit d632fa1 into codeigniter4:develop Aug 17, 2022
@datamweb datamweb deleted the update-shield-setup-command branch August 17, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datamweb @kenjis @MGatner