Skip to content

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 2, 2022

Fixes #465

Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kenjis, why do we send email to a user who is not active yet through magic link?
Wouldn't it be better to display the error on the Magic Link page before sending the email?
I always have a problem with sending unnecessary emails.

@kenjis
Copy link
Member Author

kenjis commented Nov 4, 2022

The user has not activated their account, maybe because they have not received the email for activation.

@datamweb
Copy link
Collaborator

datamweb commented Nov 4, 2022

Well, this is not a reason for us to allow the magic link to be sent to it email.
If he did not receive the activation email(6 code), he should apply again from 'auth/a/show', not through the magic link.

@kenjis
Copy link
Member Author

kenjis commented Nov 4, 2022

If the session is expired, no way to get auth/a/show when they forget the password.
If they know their password, they don't need to go magic link page.
They can go login page.

@kenjis kenjis requested review from jozefrebjak and datamweb and removed request for jozefrebjak November 5, 2022 01:39
@kenjis kenjis force-pushed the fix-pending-registration-magic-link-error branch from 85fa45c to 924ec54 Compare November 5, 2022 23:50
@kenjis kenjis requested review from MGatner and removed request for jozefrebjak November 6, 2022 23:26
@kenjis kenjis merged commit 32eb7e7 into codeigniter4:develop Nov 8, 2022
@kenjis kenjis deleted the fix-pending-registration-magic-link-error branch November 8, 2022 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Error exception occurs when a user with pending registration tries to log in.
4 participants