-
Notifications
You must be signed in to change notification settings - Fork 144
fix: Error exception occurs when user with pending activation tries magic-link login #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Error exception occurs when user with pending activation tries magic-link login #503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kenjis, why do we send email to a user who is not active yet through magic link?
Wouldn't it be better to display the error on the Magic Link page before sending the email?
I always have a problem with sending unnecessary emails.
The user has not activated their account, maybe because they have not received the email for activation. |
Well, this is not a reason for us to allow the magic link to be sent to it email. |
If the session is expired, no way to get |
Co-authored-by: Pooya Parsa Dadashi <pooya_parsa_dadashi@yahoo.com>
Co-authored-by: MGatner <mgatner@icloud.com>
85fa45c
to
924ec54
Compare
Fixes #465