Skip to content

Update failed tests for CI4.3.0 #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 12, 2023
Merged

Update failed tests for CI4.3.0 #597

merged 8 commits into from
Jan 12, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 11, 2023 •
edited
Loading

Needs #595

See #596

  • update tests
  • add psalm baseline

@kenjis kenjis changed the title Update failed tests for ci4.3.0 Update failed tests for CI4.3.0 Jan 11, 2023
@kenjis kenjis force-pushed the update-failed-tests-for-CI4.3.0 branch from 8fa33c3 to addcf28 Compare January 11, 2023 05:54
@kenjis
Copy link
Member Author

kenjis commented Jan 11, 2023

All checks have passed. 🎉

@kenjis kenjis marked this pull request as draft January 11, 2023 08:24
@kenjis kenjis mentioned this pull request Jan 11, 2023
Merged
@kenjis kenjis force-pushed the update-failed-tests-for-CI4.3.0 branch from addcf28 to be6dfe7 Compare January 12, 2023 08:30
kenjis added 8 commits January 12, 2023 20:08
@kenjis
test: fix Model::update() usage
7dd6356
@kenjis
test: update test with CITestStreamFilter
5e420d3
@kenjis
test: update timezone for tests
7e50795
@kenjis
chore: add skip
36ea567
@kenjis
chore: update psalm_autoload.php
e9f0bc8
@kenjis
chore: add baseline
688e88d 
vendor/bin/psalm --set-baseline=psalm-baseline.xml
@kenjis
chore: add baseline
80166b4 
ERROR: ReservedWord - src/Controllers/MagicLinkController.php:155:9 - 'resource' is a reserved word (see https://psalm.dev/095)
        $identityModel->delete($identity->id);

ERROR: ReservedWord - src/Models/GroupModel.php:30:17 - 'resource' is a reserved word (see https://psalm.dev/095)
        $rows = $this->builder()
            ->select('group')
            ->where('user_id', $user->id)
            ->get()
@kenjis
docs: remove unneeded @phpstan-ignore-next-line
cb81db0
@kenjis kenjis force-pushed the update-failed-tests-for-CI4.3.0 branch from d97b295 to cb81db0 Compare January 12, 2023 11:08
@kenjis kenjis marked this pull request as ready for review January 12, 2023 11:09
datamweb
datamweb approved these changes Jan 12, 2023
View reviewed changes
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiiiiice!

@kenjis kenjis merged commit bf80875 into codeigniter4:develop Jan 12, 2023
@kenjis kenjis deleted the update-failed-tests-for-CI4.3.0 branch January 12, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @datamweb