fix: phpstan errors for phpstan-codeigniter (v1.4.0.70400) #898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
reviewed
Oct 12, 2023
datamweb
force-pushed
the
fix-new-CI-phpstan
branch
from
e850b4d to
e167b69
Compare
|
@kenjis see here, phpunit /PHP 7.4 - OCI8 passed.🤒 |
datamweb
changed the title
|
Oh, yes! It probably fails because Oracle happens to take a long time to start up. |
kenjis
approved these changes
Oct 12, 2023
|
@kenjis thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain what you have changed, and why.
Checklist: