Skip to content

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 3, 2023

Description
It seems the order of array items changed by the library upgrade.

1) Tests\Unit\Authentication\JWT\JWTManagerTest::testIssueAddHeader
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
 Array &0 (
+    'typ' => 'JWT'
     'extra_key' => 'extra_value'
-    'typ' => 'JWT'
     'alg' => 'HS256'
 )

/home/runner/work/shield/shield/tests/Unit/Authentication/JWT/JWTManagerTest.php:186
phpvfscomposer:///home/runner/work/shield/shield/vendor/phpunit/phpunit/phpunit:106

https://github.com/codeigniter4/shield/actions/runs/7073301556/job/19253043215?pr=963

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the testing Pull requests that changes tests only label Dec 3, 2023
It seems the order of array items changed by the library upgrade.
@kenjis kenjis force-pushed the fix-JWTManagerTest branch from 307ac67 to 7b69071 Compare December 3, 2023 00:24
@datamweb datamweb merged commit 8de5f73 into codeigniter4:develop Dec 3, 2023
@kenjis kenjis deleted the fix-JWTManagerTest branch December 3, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Pull requests that changes tests only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants