Skip to content

add new favicons #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2022
Merged

add new favicons #305

merged 1 commit into from
Aug 3, 2022

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Jul 31, 2022

resolve #303

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2771128269

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.923%
Totals Coverage Status
Change from base Build 2765476896: 0.0%
Covered Lines: 220
Relevant Lines: 286
💛 - Coveralls

MGatner
MGatner requested changes Aug 1, 2022
View reviewed changes
Copy link
Collaborator

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The favicon sections are completely duplicated across the two layouts and should probably be extracted into their own view file. That doesn't need to be done in this PR, but please respond about SVG file format for line breaks.

@Arhell Arhell marked this pull request as draft August 1, 2022 09:38
@Arhell Arhell marked this pull request as ready for review August 2, 2022 09:59
MGatner
MGatner approved these changes Aug 2, 2022
View reviewed changes
Copy link
Collaborator

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Arhell Arhell merged commit c23d559 into develop Aug 3, 2022
@Arhell Arhell deleted the add-favicon branch August 3, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add svg favicon
3 participants
@Arhell @coveralls @MGatner