Chore/149448565/write documentation #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-models Chore/148443911/create database models
Merge Staging
Merge staging to master
Finishes #149340967
chore(finish): add CI tools badges
update documents, users and search spec files with new jwt token add .codeclimate.yml update .travis.yml update readme Finishes #149346335
chore(finish): fix README
encapsulate the tokens edit .codeclimate.yml edit .travis.yml edit readme Finishes #149386955
chore(finish): abstract tokens
edit helper.js and jwt.js edit user, document models edit users test edit readme add admin privileges Finishes #149448565
|
Changes Unknown when pulling 8951b4a on chore/149448565/write-documentation into ** on staging**. |
| [](https://travis-ci.org/codejockie/document-manager) | ||
| [](https://codeclimate.com/github/codejockie/document-manager) | ||
| [](https://coveralls.io/github/codejockie/document-manager?branch=master) | ||
| [](https://codeclimate.com/github/codejockie/document-manager/coverage) |
There was a problem hiding this comment.
What's the essence of having two coverage badges in your README?
There was a problem hiding this comment.
No reason, just a way of getting familiar with using both.
| env: | ||
| global: | ||
| secure: dNoO3Vkh6g4IpO3jRODy1UKa1tr4wLtbAKWbWxGdRcnPcgvKlwCNlVD0T7YMQf8RTsGUoBPDE+kEO/0RXDyjf7VVnkqUOpfAy74fw7ZiOHdHJvfHMFUIoXdQYdYiwjSmyNScxrINngXt5fp8MGqeUCMmLAEqHnQT+qTcIjIfN2Oj+2XrDxH5XsJQLWbZDReANOpvVU/xgoOD01KdJP31H/UsH2xp1YVUdfkAWG8CpxmBmJhehrOAIN/pv2n87fKPugn24F64UAZrKYKKwt/T3PJ7Jyr0f3TXwl+jhZxvcIakxfhaMJfSZjHRBZ/AxnlbsIcfWZ+5nbbJ/ZpTJxgvChu0DVz5GYR2OfQoZxS32XnCPzsRaHSAvlGfkeDBBauSHuTE5LO87SIG8FhG2TUaCMFfwrhyrlCQ7/5JUWsBcxxIpoOWqkr9NKIU/CtXSEoat77u/2wQNTJf78PP1sFJfh2QdOgNRtbATET5JhLusSt5mgS/L8djpA87KLPITRM2wzEYK5nKek4rOli3Lbr3CEPhuhBuEjE9bGoTavQfyDCwIPY4ivGRLeuegYi3Fej0fttPKzg5zto2Yn5VAgoyvPZmg4c5WPeMtw/bVITeMZ//att+INoOZ3e+IfFKelxBDPfHWjfzOrLcg1205o8n0gGD9yTHNv1vBG8zPqptP9c= | ||
| - secure: XyRi4wHLXcjZdJ2vA+NKTAyZLvWxIu1OyjxDzhAM/fx2vQLVcFwV9s1d6H+J8JBokL/0//5UsCjzyjbeoZbxn/rLlCdAG4EeS7o4Ua4WFlssFUTaLvsuJQ0nF/RlOM7ztEkSroM5521jdnxqmli6GPBZexcqJCAIK+3GT0CxcP2w03ziQYsMa0F6qoEidzEVNYduK7a43yrlV2Ik56OEOPEYq/PBFl7pfwUR0w7iykn1Diy66HxYRqYGXko/ePE4p0J4bLzkE/wKqN6FtXcsRoGEG3x7S+uBvmPHBBd/WpMDTr9czMUL4a5CDReev+oJLzJyOvnl1qVU0XOOnkLB8GCYG4nPYxv7zvOs/Zktu4Hdh971oWvxxXozzjNz5dmQOSyM/Fp8Knjhzk80dbd/ytTnGThQuzmXVtO+VJm+snFw8HVIf2ZG0cQoUa6bh6PuBf9Njnzit410k0sdkwsXsdiO7DbACiF4deQ89kAGaYR6X6xpCuSciEbK4f0GrTAYIqatsNFcWTgA9eL5vYEPIcoHtILsZcaNfEeeKnk0qmDk6nO1BHZDAw2xlrKWzionNNJ2Skgi+1cGHE12CnX+ovJ8+P8Mr9ipxch355rWaSKh7uZBMFFJ4sn8reZVrpnMtzw4QVthZKkIJ6IoZ4wTWMi334wsNTgE2+hr2RsUq84= |
There was a problem hiding this comment.
This is a secret and as such should not be here. You don't even need this much in your .travis.yml file
There was a problem hiding this comment.
Actually it's an encrypted secret that can only be interpreted by Travis CI
tests/routes/documents.spec.js
Outdated
| chai.use(chaiHttp); | ||
|
|
||
| const authToken = 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwiZW1haWwiOiJrZW5uZWR5Lm53YW9yZ3VAYW5kZWxhLmNvbSIsInVzZXJuYW1lIjoiY29kZWpvY2tpZSIsImlhdCI6MTUwMDY2MTAwMywiZXhwIjoxNTAwOTIwMjAzfQ.8x36eu9hgEGkrWCYcH2ImA2z7N7OXtzOazVRM0GlaEA'; | ||
| const authToken = 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwiZW1haWwiOiJrZW5uZWR5Lm53YW9yZ3VAYW5kZWxhLmNvbSIsInVzZXJuYW1lIjoiY29kZWpvY2tpZSIsImlhdCI6MTUwMDcyODYxMCwiZXhwIjoxNTMyMjY0NjEwfQ.mn1ns_DZzP7vZKYR7_0EWm-8-HF_jk59jCQCmI0V6WY'; |
There was a problem hiding this comment.
All these tokens can be hidden in your .env file.
There was a problem hiding this comment.
I've done that, it's on the master branch already. Good you noticed.
| chai.use(chaiHttp); | ||
|
|
||
| const authToken = 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwiZW1haWwiOiJrZW5uZWR5Lm53YW9yZ3VAYW5kZWxhLmNvbSIsInVzZXJuYW1lIjoiY29kZWpvY2tpZSIsImlhdCI6MTUwMDcyODYxMCwiZXhwIjoxNTMyMjY0NjEwfQ.mn1ns_DZzP7vZKYR7_0EWm-8-HF_jk59jCQCmI0V6WY'; | ||
| const authToken = process.env.AUTH_TOKEN; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#149448565 write api documentation