add TypeScript keywords + future reserved keywords

[leoortizz]

add the following keywords:

• enum
• implements
• interface
• package
• private
• protected
• public
• type

@marijnh I think that ideally some should be TypeScript only, also some should be scoped to the strict mode per the spec, but that would require greater changes. In the meantime I think that these should be added sooner rather than later as currently they can't be styled.

[marijnh]

I think that these should be added sooner rather than later as currently they can't be styled.

What does that mean? If you turn on TypeScript, these should all be highlighted correctly. Adding them as completions does not affect whether they are styled or not.

Attached patch adds this in a way where it only takes effect when TypeScript is actually enabled, and using snippets where appropriate.

[leoortizz]

I think that these should be added sooner rather than later as currently they can't be styled.

What does that mean? If you turn on TypeScript, these should all be highlighted correctly. Adding them as completions does not affect whether they are styled or not.

I'm defining my own syntax highlighting styles with syntaxHighlighting(HighlightStyle.define(TagStyle[])), then using tags as {tag: tags.keyword, color: 'var(--code-keyword)'}.

I meant that before this change these keywords were being identified as something else, then we had to style them as something else, not keywords as they are.

Attached patch adds this in a way where it only takes effect when TypeScript is actually enabled, and using snippets where appropriate.

Thanks!

[marijnh]

I meant that before this change these keywords were being identified as something else, then we had to style them as something else, not keywords as they are.

Right. But that's not accurate (that array you changed has no effect at all on the parse tree or highlighting).