This repository was archived by the owner on Apr 13, 2025. It is now read-only.
Implement function to find the nodecg installation by ourselfs #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we're using [find-up](https://www.npmjs.com/package/find-up) to traverse the filesystem and find the nodecg installation if the user is an subdirectory like `bundles/`. To reduce our dependencies we can simply implement this ourselfs. I can't remember why I used `find-up` in the first place as using it is almost harder than implementing it directly, lol.
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we're using find-up to traverse the filesystem and find the nodecg installation if the user is an subdirectory like
bundles/.To reduce our dependencies we can simply implement this ourselfs. I can't remember why I used
find-upin the first place as using it is almost harder than implementing it directly, lol.