-
Notifications
You must be signed in to change notification settings - Fork 26
CUDA Interop Exercise #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, looks good
add_executable (sycl_sgemv sycl_sgemv.cpp) | ||
target_compile_features(sycl_sgemv PUBLIC cxx_std_17) | ||
target_compile_options(sycl_sgemv PUBLIC ${SYCL_FLAGS}) | ||
target_compile_definitions(sycl_sgemv PUBLIC CUDA_NO_HALF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be worth a comment as to why this is needed
Co-authored-by: Ruyman <ruyman@codeplay.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, feel free to change that from must to will if you like, sounds a bit less authoritative :-)
Exercise 01: SYCL interop | ||
------------------------------- | ||
|
||
In this exercise, you must implement an `interop_task` to let a `SYCL` application call `cuBLAS`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
must -> will
This PR contains a new exercise, as well as some minor corrections to the examples 1 & 2.