Skip to content

Conversation

nyalloc
Copy link
Contributor

@nyalloc nyalloc commented Jun 3, 2020

This PR contains a new exercise, as well as some minor corrections to the examples 1 & 2.

@nyalloc nyalloc requested a review from Ruyk June 3, 2020 20:02
Copy link
Contributor

@Ruyk Ruyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, looks good

add_executable (sycl_sgemv sycl_sgemv.cpp)
target_compile_features(sycl_sgemv PUBLIC cxx_std_17)
target_compile_options(sycl_sgemv PUBLIC ${SYCL_FLAGS})
target_compile_definitions(sycl_sgemv PUBLIC CUDA_NO_HALF)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be worth a comment as to why this is needed

Co-authored-by: Ruyman <ruyman@codeplay.com>
Copy link
Contributor

@rodburns rodburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to change that from must to will if you like, sounds a bit less authoritative :-)

Exercise 01: SYCL interop
-------------------------------

In this exercise, you must implement an `interop_task` to let a `SYCL` application call `cuBLAS`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must -> will

@rodburns rodburns merged commit da2fa7d into master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants