Add hooks for setting bounds and permissions on exported pointers. #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidchisnall
force-pushed
the
cheri-hooks
branch
2 times, most recently
from
8f568c5 to
b1b6194
Compare
|
(Rebased, now applies cleanly) |
|
The change makes sense, but it doesn't look like this PR changes |
|
I also didn't change that file in #78. I guess I need to apply the same change from that as well? |
On a CHERI system, the pointers into the Microvium heap give full read-write access to the entire heap. This means that bounds errors (or passing string pointers to functions that try to mutate their arguments) will corrupt VM state. The two hooks are: - Apply bounds to this pointer. - Remove the ability to load pointers or store through the pointer. Both of these default to doing nothing, but no CHERI platforms they can be a csetbounds / candperms instruction.
davidchisnall
force-pushed
the
cheri-hooks
branch
from
b1b6194 to
e4709f2
Compare
|
I've pushed an update that hopefully fixes it for the previous commit as well. |
|
Yeah, looks good. Sorry, I should have caught that in the other PR as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a CHERI system, the pointers into the Microvium heap give full read-write access to the entire heap. This means that bounds errors (or passing string pointers to functions that try to mutate their arguments) will corrupt VM state.
The two hooks are:
Both of these default to doing nothing, but no CHERI platforms they can be a csetbounds / candperms instruction.