Skip to content

Conversation

DivyMohan14
Copy link
Contributor

No description provided.

Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but it might be better to conditionally set the header on the specific routes.

@DivyMohan14
Copy link
Contributor Author

This works, but it might be better to conditionally set the header on the specific routes.

Makes sense went through Huma docs, saw that this might be the best pattern according to the docs, lemme know if there is any better approach to this

created a central middleware, pluged into the sse routes

@johnstcn
Copy link
Member

Thanks! I added some unit tests on top of your branch in c47bb10 -- would you mind cherry-picking that in or adapting those into your branch? Chef's choice.

@DivyMohan14
Copy link
Contributor Author

Thanks for adding the unit tests :)
cherry picked them into the branch

@johnstcn johnstcn linked an issue Sep 12, 2025 that may be closed by this pull request
@johnstcn johnstcn merged commit 05cdee1 into coder:main Sep 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSE connections hang in Coder environments due to proxy buffering

2 participants