feat: file upload feature #98
Conversation
|
From a UX perspective, I think showing a dialog after clicking the upload button feels different from how similar tools usually behave. IMO, clicking the upload button should immediately open the file picker. Drag and drop could happen directly on the screen or be tied to the “prompt area.” This would align more closely with the approach used by ChatGPT or Gemini. That said, I’m not sure what you’ve already aligned on with the PMs. cc: @matifali |
|
✅ Preview binaries are ready! To test with modules: |
|
✅ Preview binaries are ready! To test with modules: |
@BrunoQuaresma addressed the comment, requesting a re-review |
There was a problem hiding this comment.
My main concern is the use of any in several places—we should avoid it when possible. TypeScript has good guidance on typing errors more precisely; I’m happy to share a reference if that helps.
https://kentcdodds.com/blog/get-a-catch-block-error-message-with-typescript
That said, I’m approving the PR so you’re not blocked. For significant changes, it would be great to include a screenshot or short demo next time.
|
@BrunoQuaresma thanks for sharing the blog, it was very helpful. |
|
✅ Preview binaries are ready! To test with modules: |
|
✅ Preview binaries are ready! To test with modules: |
1 similar comment
|
✅ Preview binaries are ready! To test with modules: |
Description
/uploadto upload the files/folders.