Allow file downloads

[kylecarbs]

Should be able to drag-and-drop from the file browser to my local machine.

[rubysown]

Having an option to disable this downloading feature would be nice as well when it is added - I know for example the industry I'm in (financial data) wouldn't want this allowed.

[nhooyr]

@rubysown couldn't someone just copy and paste the file?

[rubysown]

@nhooyr Yes. That might be easy for small files but not large ones. It's just a suggestion from a real-world scenario I've had to deal with, that's all.

Edit - just some extra information: we launch code-server on behalf of our employees in an environment where they have data loaded and other scripts and such. We don't allow external access, so really anything we can do to strengthen the protection helps a lot. Of course, this would never stop anyone determined but anything helps I guess.

[woshiniming007]

need this feature

[kylecarbs]

microsoft/vscode#93599 is tackling this.

[nhooyr]

Also somewhat related is #1292

[blaylockbk]

In another similar server app, JupyterLab (https://jupyter.org/), you can drag and drop a file from local to the remote directory, but you can't drag a file from the remote to local (just like in code-server). However, JupyterLab does have an option to download a file from the right-click context menu. Not sure how they do that, but it would be nice if this was in vscode.

[sr229]

This seems to be in the works for the upstream side IIRC, might be worth a look.

[woshiniming007]

@nhooyr It seems the VSCode 1.51 version has added the function:

https://code.visualstudio.com/updates/v1_51#_download-folders-edge-chrome

[code-asher]

1.51.1 has been merged and this'll be released with 3.7.2.

[lsc196]

Having an option to disable this downloading feature would be nice as well when it is added . I know for example the industry I'm in (IT) wouldn't want this allowed. Improve code security

[code-asher]

@lsc196 I opened #2426 to address this.