-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Closed
Labels
upstream:vscodeNeeds to be fixed upstream in VSCodeNeeds to be fixed upstream in VSCode
Description
Hi there! 👋
I created a vs-code extension for code sharing. For running extension I'm using code-server. I'm using web socket for real-time sending and receiving messaged (In this case users mouse position or text highlights).
I open every files which I want to share in browser as tabs.
BUT
When I closed all tabs, my extension goes deactivated, web socket is stopped and I got error.
OS/Web Information
- Web Browser: chrome, firefox
- Local OS: centos
- Remote OS: centos
- Remote Architecture: code-server
code-server --version
: code-server-3.9.1-linux-amd64
Steps to Reproduce
- Run code-server with ( ./code-server ) command
- Copy my extension into ( .local/code-server/extensions ) folder
- Open two browser (chrome/firefox) with (http://localhost:8080) address
- Open share folder in browsers
- Open files inside share folder as tab in browsers
Expected
When user1(chrome) select part of text, user2(firefox) should see that in it's own browser with different color, this should happens for user2 (Like micro-soft live share)
Actual
Users can select code and other user can see selection of other users BUT when closing all files error accures
Screenshot
This issue can be reproduced in VS Code: Yes
Metadata
Metadata
Assignees
Labels
upstream:vscodeNeeds to be fixed upstream in VSCodeNeeds to be fixed upstream in VSCode