Different / weird key mappings in terminal in Chrome

[jmbarbier]

OS/Web Information

• Web Browser: Chrome 93.0.4577.63 64 bits / Firefox 91.0.2 64 bits
• Local OS: Ubuntu 20.04
• Remote OS: Ubuntu 20.04
• Remote Architecture: amd4
• code-server --version: 3.11.1 c680aae

Steps to Reproduce

1. With a french keyboard
2. Open a terminal under Chrome
3. Type some non-letter keys (example : @&é"'...)

Expected

The letters @&é"' shoud appear in terminal

Actual

• with firefox : the letters @&é"' appear in terminal (good)
• with chrome : the letters '123456 appear in terminal (bad)

Screenshot

Notes

This issue is only present in terminal, for editors all keys are OK for all browsers.
Changing vscode keyboard layout from us to fr have absolutely no effect.
Trying to remap keys in keyboardLayout.json have no effect.

Code-server runs from these 2 Dockerfiles :

https://dev.solidev.net/school/develspace/develspace-services/-/blob/develop/base/Dockerfile
https://dev.solidev.net/school/develspace/develspace-services/-/blob/develop/vscode/Dockerfile

This issue can be reproduced in VS Code: No

[jsjoeio]

Hmm 🤔 I wonder if this is an upstream issue. Do you mind seeing if this can be reproduced in Xterm.js?

In the meantime, I'll see if I can reproduce locally. Just gotta find a French keyboard...

[jsjoeio]

I'm using a French keyboard input on my macOS + Brave and I'm not sure if I'm reproducing or not 🤔 Very hard to tell since I'm not sure which keys I should be hitting. Let me know exactly what keys I should hit on a US QWERTY keyboard and I can try to reproduce.

Screen.Recording.2021-09-02.at.10.37.16.AM.mov

Other thought, could this be a browser issue?

[bcouetil]

I have the exact same problem (and I'm french too).

In fact, the numbers act like an US QWERTY keyboard, so when hitting the first number key, we get a 1 and should get a &. Combined with MAJ we get a ! and should get a 1.

If this can help, I'm on Ubuntu and my keyboard is french but my language is English :

[bcouetil]

And Opera browser does not have the problem, even being a chrome-like browser.

And same problem with v3.10.2

[jmbarbier]

@jsjoeio nice catch, the behaviour is exactly the same for xterm.js, in https://xtermjs.org/ for example (and also in jupyterlab).

@bcouetil exact, this seems to be a Chrome-only problem, i just tried https://w3c.github.io/uievents/tools/key-event-viewer.html on the following browsers

• Chromium Version 93.0.4577.63 (Build officiel) snap (64 bits)
• Edge Version 95.0.997.1 (Version officielle) dev (64 bits)
• Firefox 91.0.2 (64 bits)

while in Chrome, keypress and keydown events are mismatched :

So this is clearly an upstream issue, feel free to close this.

[jmbarbier]

Closing in favor of https://bugs.chromium.org/p/chromium/issues/detail?id=1245196

[jsjoeio]

Wow, that's cool to see you figured out it's upstream in Chromium! Thanks for double-checking and linking upstream!

[jmbarbier]

Follow-up : https://bugs.chromium.org/p/chromium/issues/detail?id=1248395 is closed and fixed, terminal works great now... 🍾

[jsjoeio]

Amazing! 🎉 Thanks for following up and linking!